fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(logs): remove not so useful logs

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(logs): remove useless logs

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

chore: prepare for 3.16.6 release

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8382 from nextcloud/backport/8370/stable-3.16

[stable-3.16] fix(readonly): better handling of ACL on read-only files on windows

fix(readonly): better handling of ACL on read-only files on windows

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8381 from nextcloud/backport/8356/stable-3.16

[stable-3.16] fix(crash): debug builds would not try to remove a not found job

fix(crash): debug builds would not try to remove a not found job

in release builds we would happily try to remove an element from QList
with invalid index (-1) if the job is not found

avoid doing this in release builds and keep teh assert in debug builds

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8380 from nextcloud/backport/8379/stable-3.16

[stable-3.16] fix(accountmanager): use defaults from configFile if setting was not present

style: access static members through `::`

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(accountmanager): use defaults from configFile if setting was not present

This prevented e.g. "launchOnSystemStartup" to be set on a fresh
installation.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8378 from nextcloud/backport/8375/stable-3.16

[stable-3.16] fix(activitylistmodel): fix activities for e2ee files

fix(activitylistmodel): fix activities for e2ee files

the sharing/activity button was supposed to be hidden, but a later
change forgot to adapt the variable used for querying the file metadata
so it never could determine the e2e-status

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8348 from nextcloud/backport/8347/stable-3.16

[stable-3.16] fix(msi): set the REBOOT property in the MSI

fix(msi): set the REBOOT property in the MSI

A value of `ReallySuppress` will not display a reboot prompt whenever
the `ForceReboot` action was run, or whenever a reboot was scheduled
(e.g. by `FilesInUse`).  Apparently this will not reboot the machine on
its own either.

`winget` sets this property in its manifest[0], and according to reports in
issue #5369 this seems to work.

See also: https://learn.microsoft.com/en-us/windows/win32/msi/reboot

[0]: https://github.com/microsoft/winget-pkgs/blob/0b40904d1480f67d48c6d8e2ac7f27b31aa566c7/manifests/n/Nextcloud/NextcloudDesktop/3.16.5/Nextcloud.NextcloudDesktop.installer.yaml#L16

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8346 from nextcloud/backport/8220/stable-3.16

[stable-3.16] fix(macOS): Fix prompting of user for permission to access "other" apps' data

feat(mac-crafter): Use our default entitlements file during default mac-crafter build run

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

feat(macOS): Add entitlements file

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

feat(mac-crafter): Add entitlements path option to codesign command

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

feat(mac-crafter): Add ability to codesign with an entitlements file

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

chore: prepare for release 3.16.4

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8332 from nextcloud/backport/8330/stable-3.16

[stable-3.16] fix(lockfilejobs): ensure using correct file path

fix(lockfilejobs): ensure using correct file path

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8328 from nextcloud/backport/8290/stable-3.16

[stable-3.16] fix(filesystem): only change folder permissions if required

fix(propagator): touch folder paths if permissions changed

Extra safeguard to ensure that the usage of
`FileSystem::setFolderPermissions` won't start a new sync run if
FolderWatcher/inotify detects a change in the file metadata...

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(filesystem): only change folder permissions if required

On Linux changing the permissions causes inotify to create a IN_ATTRIB
event -- even if the permissions stays the same.

Such an event is passed to the filesystem watcher which lets the client
schedule a new sync run.  In certain conditions, this could happen
during every sync run...

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8327 from nextcloud/backport/8297/stable-3.16

[stable-3.16] fix(permissions): handle properly CanRead permission from server

fix(permissions): handle properly CanRead permission from server

if Readable permissions is missing, do nto try to download the file

if a file was downlaoded but Readable permission is now missing, remove
it

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8326 from nextcloud/backport/8246/stable-3.16

[stable-3.16] fix(readonly): use native separator in paths before calling windows API

fix(readonly): use native separator in paths before calling windows API

we need platform native separators for file paths that will be used in
native Windows platform specific APIs

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8322 from nextcloud/backport/8321/stable-3.16

[stable-3.16] Bugfix/windows regressions

fix(windows): when deleting a file use safe long windows path

will avoid getting a content access denied error because some paths is
too long for windows default limit and has to use the special syntax for
long path

see https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(readonly): avoid changing permissions when not needed

in FilePermissionsRestore, first checks the folder permissions before
changing them

will avoid useless call changing permissions when not needed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(readonly): avoid implicit hydration when modifying permissions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8325 from nextcloud/backport/8243/stable-3.16

[stable-3.16] fix(readonly): apply ACL also to files inside read-only folders

fix(readonly): apply ACL also to files inside read-only folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8324 from nextcloud/backport/8241/stable-3.16

[stable-3.16] fix(readonly): enable MOVE rollback when folder is read-only

fix(readonly): enable MOVE rollback when folder is read-only

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8323 from nextcloud/backport/8240/stable-3.16

[stable-3.16] fix(rename): avoid failing hard when rename is rejected by server

fix(rename): avoid failing hard when rename is rejected by server

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

feat(windows): use cmake to configure windows integration DLL version

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8316 from nextcloud/backport/8277/stable-3.16

[stable-3.16] feat(mac-crafter): retry code-signing attempts

feat(mac-crafter): retry code-signing attempts

This step sometimes fails with an error such as: "A timestamp was
expected but was not found.".  Any code-signing errors will result in
the notarisation step to fail.

Apparently this might be due to intermittent network issues.  Let's just
retry codesigning a couple of times in the case it fails ...

See also: https://developer.apple.com/documentation/security/resolving-common-notarization-issues#Include-a-secure-timestamp

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8317 from nextcloud/backport/8217/stable-3.16

[stable-3.16] fix(appimage): move VFS plugins to AppDir

fix(appimage): move VFS plugins to AppDir

This allows the AppImage build to find and load the experimental VFS
plugins, and not crash with:

    [ critical plugins /home/user/src/common/vfs.cpp:250 ]: Could not load plugin: not existent or bad metadata "nextclouddevsync_vfs_suffix"
    [ fatal default /home/user/src/gui/folderman.cpp:326 ]: Could not load plugin
    [1]    72936 IOT instruction (core dumped)  ./nextclouddev-master-x86_64.AppImage

Fixes #7135
Fixes #7194
Fixes #7465

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8315 from nextcloud/backport/8178/stable-3.16

[stable-3.16] Bugfix/version windows integration improve install

chore: add missing backport for VERSION.cmake

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

feat(msi): do not schedule reboots ourselves

let's have the MSI RestartManager take care of that

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
[skip ci]

fix(windows): add missing version to cfapi shell integration DLL

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

feat(windows): use cmake to configure windows integration DLL version

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(msi): force termination of stuck processes

Stopping the Windows Explorer process does not always work.  Per default
the MSI Restart Manager will display a warning message after a timeout,
and not attempt to restart Explorer afterwards -- resulting in a black
screen if no other window is open.

Setting the property `MSIRMSHUTDOWN` to `1` will force the termination
of the process when the timeout is reached, which finally allows the
Explorer to be restarted.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(msi): do not completely remove the previous installation when updating

The MSIs we distribute perform so-called "major upgrades".

From the Microsoft docs, we learn that...

> A typical major upgrade **removes a previous version** of an
> application and installs a new version.

Indeed that was the case -- the previous version is uninstalled
completely before the new version gets installed.  Since we install an
extension that's loaded by explorer, the installer will ask the user to
restart Windows Explorer during the uninstallation of the previous
version (and restarting that might not always work as expected).

There is a way to change this behaviour though, using Wix3's
`MajorUpgrade` element.  Through its `Schedule` property it's possible
to define when the removal of the previous version should occur.

The previous value `afterInstallInitialize` is one of two values that
perform a complete uninstall/install sequence.  The new value
`afterInstallExecute` will install new files on top of the previous
installation (depending on the `REINSTALLMODE` I guess) and remove
older files that are not present.
In the case of the extensions this means that the .dlls from the
previous installation will not be touched, as long as the version
embedded in the DLL info didn't change.  This results in the installer
no longer requesting Windows Explorer to restart, which is a big plus :D

I also changed the REINSTALLMODE to `dmus` to allow downgrades as well.

With this change, the request to restart Windows Explorer should
hopefully happen only once an installation was made using an MSI that
contains this change.  Further updates will only request a restart if
the DLL version of these extensions change...

See also:
  - https://learn.microsoft.com/en-us/windows/win32/msi/major-upgrades
  - https://docs.firegiant.com/wix/schema/wxs/majorupgrade/#attributes:~:text=Schedule

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(msi): use standard replace mode for MSI installer

shoudl enable replacing files during install happen only when needed
instead of always

will need to take care of migration from older releases

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8314 from nextcloud/backport/8181/stable-3.16

[stable-3.16] fix(gui): handle invalid file name edge case on Windows

fix(gui): don't append another slash to the relative path

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

refactor: add new filePath method to folder

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(gui): always hide the error label if we are allowed to rename

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(gui): update info text with proper invalid characters

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(gui): handle invalid file name edge case on Windows

File names like "c:blah" would break the usage of the dialogue,
displaying a path like "c://blah" instead.

Apparently `QDir::filePath` checks if the passed file name is an
absolute file name using `!QFileInfo::isRelative`, which is the case if
the second character in the string is a colon -- probably indicating a
drive letter.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8313 from nextcloud/backport/8280/stable-3.16

[stable-3.16] fix(AppImage): bundle client translations

fix(AppImage): bundle client translations

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8312 from nextcloud/backport/8276/stable-3.16

[stable-3.16] fix(delete): fix move to trash in read-only folders

fix(moveToTrash): enable use of move to trash in some automated tests

should improve coverage for move to trash feature to ensure this is
working as expected by users

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(readonly): ignore move to trash for read-èonly items

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(delete): fix move to trash when parent folder is read-only

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(delete): optimize item exist checks when propagating from server

QFileInfo::exists(filename) is the fastest method

alos avoid creating too many QFileInfo instances when we need it for
multiple purposes

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(delete): always print warnings when file deletions fail

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8308 from nextcloud/backport/8228/stable-3.16

[stable-3.16] fix(migration): migrate general network settings.

fix(migration): migrate general network settings.

Signed-off-by: Camila Ayres <hello@camilasan.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>